JDK 9 RFR of JDK-8144215: Test development task for : JEP-JDK-8046565: SQE Test Plan for Platform Logging API and Service
Daniel Fuchs
daniel.fuchs at oracle.com
Wed Dec 2 08:53:55 UTC 2015
Hi Hamlin,
This looks good to me.
I can sponsor this change.
best regards,
-- daniel
On 12/2/15 8:14 AM, Hamlin Li wrote:
> Hi Daniel,
>
> Thanks for the review, I follow you suggestion to create a new RFE
> https://bugs.openjdk.java.net/browse/JDK-8144460 to track the pushing
> for this new test.
> webrev : http://cr.openjdk.java.net/~mli/8144460/webrev.01/
> old one is moved to http://cr.openjdk.java.net/~mli/8144460/webrev.00/
>
> Thank you
> -Hamlin
>
> On 2015/12/1 18:40, Daniel Fuchs wrote:
>> Hi Hamlin,
>>
>> You should probably create a new open RFE for pushing this new
>> test.
>> I'm not sure we can use internal task ids in commit/push comments.
>>
>> From looking at the test, it would be preferable to create
>> the loggers after setting up the stub that pretend that the
>> VM is not yet booted. In other words - in BootstrapLoggerAPIsTest
>> lines 53-56 should preferably be moved after line 74.
>>
>> best regards,
>>
>> -- daniel
>>
>> On 01/12/15 04:37, Hamlin Li wrote:
>>> Hi all,
>>>
>>> Would you please help to review the test development of JDK-8144215
>>> <https://bugs.openjdk.java.net/browse/JDK-8144215>: Test development
>>> task for : JEP-JDK-8046565: SQE Test Plan for Platform Logging API and
>>> Service.
>>> webrev : http://cr.openjdk.java.net/~mli/8144215/webrev.00/
>>>
>>> Thank you
>>> -Hamlin
>>
>
More information about the core-libs-dev
mailing list