RFR 8143404: Remove apple script engine code in jdk repository

Mandy Chung mandy.chung at oracle.com
Fri Dec 4 03:31:46 UTC 2015


> On Dec 3, 2015, at 5:41 PM, Sundararajan Athijegannathan <sundararajan.athijegannathan at oracle.com> wrote:
> 
> Hi,
> 
> Thanks. Updated:
> 
> http://cr.openjdk.java.net/~sundar/8143404/jdk/webrev.00/
> http://cr.openjdk.java.net/~sundar/8143404/top/webrev.00/
> http://cr.openjdk.java.net/~sundar/8143404/langtools/webrev.00/
> 

jdk/src/jdk.deploy.osx/macosx/native/libapplescriptengine
- jdk webrev didn’t show they are removed.

jdk/make/lib/Lib-jdk.deploy.osx.gmk

unshuffle_list.txt
1296 jdk/src/jdk.deploy.osx/macosx/classes/apple/security : jdk/src/macosx/classes/apple/security

since you are on this file, do you mind taking out this line as well (which was a leftover from the changeset when moving out the apple security provider to java.abs).

modules.xml

I believe this should be updated as well and jdk.deploy.osx dependency on java.desktop and java.scripting can be removed.  

I notice that there are qualified exports from sun.misc to jdk.deploy.osx that looks like they are not needed.  Run jdeps on $BUILD_OUTPUTDIR/jdk/modules/jdk.deploy.osx from your build will show the new dependency.    It’d be good to clean this up but this is not related to this change.  It’s okay with me either way.

Mandy


More information about the core-libs-dev mailing list