RFR(m): update 2: JEP 269 initial API and skeleton implementation (JDK-8139232)

Stuart Marks stuart.marks at oracle.com
Fri Dec 4 21:55:14 UTC 2015


>> I still need an official OpenJDK Reviewer.
>
> +1

Thanks.

>
> This is purely a suggestion, take it or leave it: you could use a static import for Objects.requireNonNull, that makes the current code marginally easier on the eyes (i know this area is likely to change).

Will consider for future code cleanups.

> List/Set/Map/MOAT
>>
> Update the license header date to 2015.
>
>
> Map
>>
> 1689      * The key and the value must not be null. Calling {@link Entry#setValue Entry.setValue()}
>
> s/null/{@code null}

Will fix the above.

s'marks



More information about the core-libs-dev mailing list