[8u-dev] Request for approval: 8133924: NPE may be thrown when xsltc select a non-existing node after JDK-8062518

[huizhe wang]

On 12/4/2015 3:35 PM, Aleksej Efimov wrote:
> Hi Joe, Sean,
> Thank you for the reviews and comments.
>
> Joe,
> Thank you for the suggestion. I added small test changes to address 
> your proposal. New webrev can be found here: 
> http://cr.openjdk.java.net/~aefimov/8133924/8/01/

Ok, that works.

Best,
Joe

>
> Best Regards,
> Aleksej
>
> On 12/05/2015 02:18 AM, huizhe wang wrote:
>> Hi Aleksej,
>>
>> First of all, I'm not a reviewer for 8u.
>>
>> The test is fine in proving that no NPE is thrown, which indicates 
>> the 2nd nodeset is not null. However, there's a 2nd aspect of this: 
>> it should be empty. I suggest improving the test so that it further 
>> proves that it's not only "not null" but indeed empty. To do that, 
>> you may change the 1st nodeset to return meaningful result to show 
>> that the leading function returns the 1st set, which proves that the 
>> 2nd is empty.
>>
>> Thanks,
>> Joe
>>
>> On 12/3/2015 4:25 PM, Aleksej Efimov wrote:
>>> Hi,
>>>
>>> Please, help to review and approve JDK-8133924 backport to JDK8. The 
>>> source fix is identical to JDK9 changes, but there was no test added 
>>> for this issue in JDK9.
>>>
>>> The existing 
>>> jdk/test/javax/xml/jaxp/transform/8062518/XSLTFunctionsTest.java 
>>> test was modified to test the reported problem in JDK8 and it is a 
>>> subject of review:
>>> http://cr.openjdk.java.net/~aefimov/8133924/8/00
>>>
>>> No regression tests failures were observed for the proposed fix in 
>>> JDK8 + the fix is in JDK9 for 3 months already.
>>>
>>> With Best Regards,
>>> Aleksej
>>>
>>> JBS:
>>> https://bugs.openjdk.java.net/browse/JDK-8133924
>>>
>>> JDK9 changeset:
>>> http://hg.openjdk.java.net/jdk9/dev/jaxp/rev/7c045de70a66
>>>
>>> JDK9 Review thread:
>>> http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-August/034969.html 
>>>
>>
>