RFR(m): update 2: JEP 269 initial API and skeleton implementation (JDK-8139232)
Stuart Marks
stuart.marks at oracle.com
Sat Dec 5 00:59:49 UTC 2015
On 12/4/15 12:39 PM, Roger Riggs wrote:
> Hi Stuart,
>
> List.java:
>
> - The varargs form would be more readable if the parameter was named
> 'elements' instead of 'es'.
> - ditto Map and Set
Renamed.
> Map.java:
>
> - in the @returns I would say returns "a {@code Map}" to be explicit about the
> return type.
> (ditto in Set and List to reinforce the return type)
Markup updated.
> - the exception for duplicate keys that is thrown says duplicate elements but
> it is really the keys that are duplicated.
> In the @throws clause it would be more readable to say "if there are
> duplicates in the keys"
> or as is appears in Set: "if there are any duplicate elements"
Updated wording in @throws clauses and in the exception message.
> Reviewed: +1
Thanks,
s'marks
More information about the core-libs-dev
mailing list