RFR(S): 8144723: MethodHandleImpl.initStatics is no longer needed

[Claes Redestad]

Hi Remi,

On 2015-12-07 12:42, Remi Forax wrote:
> Hi Claes,
> Makers should be declared 'private', so the constructor by default will be private.
>
> You should remove 'private' in front of TYPED_COLLECTORS, PRODUCE_BLOCK_INLINING_FORM and PRODUCE_REINVOKER_FORM because otherwise the compiler will generate methods access$xxx inside Makers to access to these fields. Those methods are unnecessary here.
>
> In TYPED_COLLECTORS, it should be
>    return new MethodHandle[1 + MAX_JVM_ARITY];

Fixed:

http://cr.openjdk.java.net/~redestad/8144723/webrev.02/

>
> otherwise, changes look fine.

Thanks!

There's been some off-list comments about whether or not this change 
might make it possible to call into java.lang.invoke in surprising 
before things are properly initialized, which might not be covered by 
available tests. I've not been able to find or produce a test that 
demonstrate any bootstrapping and think we should push this now and fix 
any unforeseen bootstrapping issues it may cause as they come in. I hope 
some reviewer agrees. :-)

/Claes