RFR 8144675: Add a filtering collector
Paul Sandoz
paul.sandoz at oracle.com
Tue Dec 8 11:25:03 UTC 2015
> On 8 Dec 2015, at 10:59, ShinyaYoshida <bitterfoxc at gmail.com> wrote:
>
> Hi Paul,
> Thank you for your review.
> (Especially, about doc comment, it's very helpful for non-native speaker like me ;) )
>
No problem. FWIW i am a native speaker and i find the documentation/specification the hardest part.
> 2015-12-08 18:27 GMT+09:00 Paul Sandoz <paul.sandoz at oracle.com>:
> Hi,
>
> Looks good.
>
> Just minor comments.
>
> Would you mind limiting the text (not the example code) in the JavaDoc to the 80 limit?
>
> Oops, I've not minded, I'll be careful.
>
> I update my webrev to take your suggestions:
> http://cr.openjdk.java.net/~shinyafox/8144675/webrev.02/
>
Small thing i forgot to mention last time (and i often forget myself):
CollectorsTest
—
76 * @bug 8071600
You need to include 8144675 in the above (space separated list)
No need for another review. I will push this week along with Tagir’s patch as well.
Many thanks,
Paul.
More information about the core-libs-dev
mailing list