RFR:JDK-8032510 : Add java.time.Duration.dividedBy(Duration)

Stephen Colebourne scolebourne at joda.org
Fri Dec 11 11:15:11 UTC 2015


Missing blank line after the new method.
Typo: "diviosr"
Replace:
 Objects.requireNonNull(divisor, "divisor is null");
with
 Objects.requireNonNull(divisor, "divisor");
to match existing JSR-310 code.

Test case looks fine.

thanks
Stephen


On 11 December 2015 at 11:07, nadeesh tv <nadeesh.tv at oracle.com> wrote:
> Hi all,
> Please review a fix for
>
> Bug Id - https://bugs.openjdk.java.net/browse/JDK-8032510
>
> Enhancement - Add java.time.Duration.dividedBy(Duration)
>
> webrev - http://cr.openjdk.java.net/~ntv/8032510/webrev.02/
>
> --
> Thanks and Regards,
> Nadeesh TV
>



More information about the core-libs-dev mailing list