RFR (JAXP): 8068839: newDuration(x) produces incorrect outputs for some values of x
Lance Andersen
lance.andersen at oracle.com
Fri Dec 11 18:07:51 UTC 2015
Hi Joe,
I think this looks OK. My only suggestion is I am not a fan of creating a one-off type of test vs integrating if at all possible a test such as this into existing test(s). The reason is it can get out of control the number of one off tests and makes it a bit harder to know the coverage if you have a slew of files to review.
Again, feel free to push, and ignore me :-)
Best
Lance
On Dec 11, 2015, at 12:54 PM, huizhe wang <huizhe.wang at oracle.com> wrote:
> This is a fix for an edge case. All tests passed after the fix.
>
> JBS:
> https://bugs.openjdk.java.net/browse/JDK-8068839
>
> webrev:
> http://cr.openjdk.java.net/~joehw/jdk9/8068839/webrev/
>
> Thanks,
> Joe
>
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
Lance.Andersen at oracle.com
More information about the core-libs-dev
mailing list