RFR 4823133: RandomAccessFile.length() is not thread-safe

[vyom]

Hi All,

Please find the updated 
webrev(http://cr.openjdk.java.net/~vtewari/4823133/webrev0.1/ 
<http://cr.openjdk.java.net/%7Evtewari/4823133/webrev0.1/>). I 
incorporated the review comments by Roger Riggs.

Thanks,
Vyom


On Tuesday 15 December 2015 10:01 PM, Roger Riggs wrote:
> Hi Yvom,
>
> Minor comments:
>
> src/java.base/share/native/libjava/RandomAccessFile.c:
>  - "length fail" might be clearer as "GetLength failed"
>
> src/java.base/unix/native/libjava/io_util_md.c:
>
>  - Please add a comment before the define of FILE_OFFSET_BITS to 
> indicate where it is used and why it is there.
>  - BTW, are there any unintended side effects?
>    Perhaps a different issue but perhaps 64 bit offsets should be used 
> everywhere
>
> src/java.base/windows/native/libjava/io_util_md.c
>  - Line 592: Using INVALID_HANDLE_VALUE is better than -1 and is used 
> elsewhere in the file
>    BTW, Testing for invalid handle might be unnecessary since the call 
> to GetFileSizeEx will fail
>    if it is invalid, yielding the same result.
>
> Roger
>
> On 12/10/2015 5:52 AM, vyom wrote:
>> Hi All,
>>
>> Please review my changes for below bug.
>>
>> Bug: JDK-4823133 : RandomAccessFile.length() is not thread-safe
>>
>> Webrev:http://cr.openjdk.java.net/~vtewari/4823133/webrev0.0/ 
>> <http://cr.openjdk.java.net/%7Evtewari/4823133/webrev0.0/>
>>
>> This change ensure that  length() does not temporarily changes the 
>> file pointer and it will make sure that there is no race
>> condition in case of multi thread uses.
>>
>> Thanks,
>> Vyom
>>
>>
>>
>>
>