Review Request 8144553: java/lang/StackWalker/StackWalkTest.java and MultiThreadStackWalk.java fail with stack overflows
Mandy Chung
mandy.chung at oracle.com
Thu Dec 17 16:07:58 UTC 2015
> On Dec 17, 2015, at 7:39 AM, Daniel Fuchs <daniel.fuchs at oracle.com> wrote:
>
> On 17/12/15 16:22, Mandy Chung wrote:
>>> On Dec 17, 2015, at 6:02 AM, Daniel Fuchs<daniel.fuchs at oracle.com> wrote:
>>> >
>>> >Hi Mandy,
>>> >
>>> >I believe it would be good to have some test that go over
>>> >the 1024 limit - as this has been useful to detect bugs
>>> >when we were actively prototyping the API.
>>> >
>>> >So maybe we should first try to reduce from 2000 to e.g. 1028?
>>> >
>> Are you relating 1024 to the MaxJavaStackTraceDepth? That is the max depth of builtin backtrace. StackWalker no longer has the maxDepth.
>
> Yes. Is this truly gone? I thought it was still lurking :-)
>
> StackStreamFactory.java
> 918: private static final int MAX_STACK_FRAMES = 1024;
>
This is for StackTrace which is used to generate Thread::dumpStack and Thread::getStackTrace with a limit on the number of stack trace elements.
Mandy
More information about the core-libs-dev
mailing list