RFR: 8145686: SimpleConsoleLogger and LogRecord should take advantage of StackWalker to skip classes implementing System.Logger

[Daniel Fuchs]

On 12/17/15 7:02 PM, Mandy Chung wrote:
>
>> On Dec 17, 2015, at 8:42 AM, Daniel Fuchs <daniel.fuchs at oracle.com> wrote:
>>
>> Hi,
>>
>> Please find below a small enhancement for the method that infers
>> the calling class name and method name in  SimpleConsoleLogger
>> and LogRecord.
>>
>> The idea is that since these methods now use the new StackWalker API
>> they should take advantage of that in order to skip classes that
>> implement System.Logger. This should make it possible for components
>> that need it to easily wrap a System.Logger (and even a j.u.l.Logger).
>>
>> 8145686: SimpleConsoleLogger and LogRecord should take advantage
>>          of StackWalker to skip classes implementing System.Logger
>> https://bugs.openjdk.java.net/browse/JDK-8145686
>>
>> webrev:
>> http://cr.openjdk.java.net/~dfuchs/webrev_8145686/webrev.00/
>
> What is the difference between skipLoggingFrame and isLoggerImplFrame?

isLoggingImplFrame stops when it finds the concrete logger 
implementation. It will unstack all the LogRecord, Handler, Filter
implementations etc... (which could be custom application classes)

skipLoggingFrame will skip everything above the first method found
on the concrete Logger implementation until it reaches something that
looks like a calling frame. In particular it should skip other
methods of the logger implementation (e.g. log() calls log(LogRecord),
default interface methods provided by the logging framework,
reflection/method handle frames etc...
In particular it should skip any Logger wrapper classes.

For instance, RMI has a logger that wraps a j.u.l.Logger so
ideally that should be skipped too...
JMX remote has a ClassLogger that should also be skipped.
etc...

-- daniel

>
> Mandy
>