RFR (xs): JDK-8072611: (process) ProcessBuilder redirecting output to file should work with long file names (win)

Roger Riggs Roger.Riggs at Oracle.com
Mon Feb 9 15:45:04 UTC 2015


Hi Thomas,

Conventionally,  File.deleteOnExit is used for file cleanup in the test.
An unexpected exception could leave the file around.  An alternative is to
use try {...} finally {file.delete};

Fixed file names can sometime cause issues if they are left around by
previous test runs or with a concurrent run of the same test on the same
system.  Can File.createTempFile be used with a suitably long prefix or 
suffix?
It would ensure a unique file name.

The rest looks good.

Thanks, Roger


On 2/9/15 8:30 AM, Thomas Stüfe wrote:
> Hi all,
>
> please review this small change at your convenience:
>
> http://cr.openjdk.java.net/~stuefe/webrevs/8072611/webrev.01/webrev/
>
> It fixes a small issue which causes ProcessBuilder not to be able to open
> files to redirect into (when using Redirect.append) on windows, if that
> file name is longer than 255 chars.
>
> Kind Regards, Thomas Stuefe




More information about the core-libs-dev mailing list