[9] RFC JDK-8068373: (prefs) FileSystemPreferences writes \0 to XML storage, causing loss of all preferences

[Roger Riggs]

Hi Brian,

Is there a particular reason to use the String form of contains(String) 
instead of indexOf(int) >= 0?
It seems more natural since the scan is for a single character.
If there is no performance difference then its does not matter.

Will there be a test?

Roger


On 2/12/2015 2:30 PM, Brian Burkhalter wrote:
> So I think this is the patch there appeared to be some consensus no in the review thread:
>
> Issue:	https://bugs.openjdk.java.net/browse/JDK-8068373
> Patch:	http://cr.openjdk.java.net/~bpb/8068373/webrev.03/
>
> (Yeah, I know I forgot once again to update the more recent copyright year - will do before push.)
>
> As a matter of historical (un)interest, the previous patches are available for scrutiny here:
>
> http://cr.openjdk.java.net/~bpb/8068373/
>
> Thanks,
>
> Brian
>
> On Feb 12, 2015, at 11:00 AM, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:
>
>> I retract my statement below. My webrev.00 was this one:
>>
>> http://cr.openjdk.java.net/~bpb/8068373/webrev.00/
>>
>> with no API changes. It follows extant style but I do not like it that much. Please compare if you have time with the adding of the IAE to the spec.