Review Request: 8073361: Missing doPrivileged in com.sun.xml.internal.bind.v2.ClassFactory

[Daniel Fuchs]

Hi Mandy,

On 20/02/15 19:54, Mandy Chung wrote:
 > This fixes a regression due to JDK-8057645 moving JAXB to ext loader
 > that was tested before the fix for JDK-8054367 went in jdk9.  This
 > was uncovered after JDK-8057645and JDK-8054367 met.
 >
 > The fix is simple.  Class.getDeclaredConstructor on a class defined
 > by the null loader will require 
RuntimePermission("accessDeclaredMembers")
 > check that needs to be wrapped with doPrivileged block.
 >
 > http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8073361/webrev.00/

The change looks OK - given that the call would have succeeded
when ClassFactory was in the boot.
You could have used limited doPrivileged but it is probably not
unnecessary.

best regards,

-- daniel

 > It doesn't change the behavior as previously when JAXB was loaded
 > by the null class loader that it always has access to any declared
 > member of any class (it's the ancestor of all class loaders).
 >
 > Mandy
 > [1] http://hg.openjdk.java.net/jdk9/jdk9/jaxws/rev/ef93f7aa0d2f