RFR: 8068790: ZipEntry/JarEntry.setCreation/LastAccessTime(null) don't throw NPE as specified

[Claes Redestad]

Hi Sherman,

On 2015-02-20 17:51, Xueming Shen wrote:
> Hi Claes, thanks for working on this one!
>
> The change looks fine. The msg indeed is more informative now, the 
> most of the usages
> of requireNonNull in jdk source code appears to pass in the name of 
> the offending parameter.

no problem, and thanks for reviewing!

/Claes
>
> -Sherman
>
> On 2/20/15 7:24 AM, Claes Redestad wrote:
>> On 2015-02-20 16:04, Seán Coffey wrote:
>>> Looks fine to me Claes. From a supportability point of view, could I 
>>> suggest that the exception string be made more informative ? (for 
>>> cases where the stack may not be present - logs etc.)
>>> i.e. "lastModifiedTime", "lastAccessTime", "creationTime".
>>
>> Thanks!
>>
>> Updated webrev: 
>> http://cr.openjdk.java.net/~redestad/jdk9/8068790/webrev.1/
>>
>>>
>>> Will you be porting this to jdk8u-dev also ?
>>
>> That seems appropriate. I'm not a JDK8 committer, though.
>>
>> /Claes
>