RFR(S): JDK-8073584 Native compilation warning in unpack code

Kumar Srinivasan kumar.x.srinivasan at oracle.com
Mon Feb 23 17:05:01 UTC 2015


Much nicer  and thanks for making these changes!.

Kumar

On 2/23/2015 6:02 AM, Dmitry Samersoff wrote:
> Hi Everyone,
>
> Webrev updated in-place (press shift-reload)
>
> http://cr.openjdk.java.net/~dsamersoff/JDK-8073584/webrev.01/
>
> Updated formatting.
>
> Hack in main.cpp replaced with true error check.
>
> -Dmitry
>
>
> On 2015-02-23 05:07, David Holmes wrote:
>> On 21/02/2015 4:27 AM, Dmitry Samersoff wrote:
>>> Hi Everyone,
>>>
>>> It's my $0.02 to the warning cleanup work. Please review:
>>>
>>> http://cr.openjdk.java.net/~dsamersoff/JDK-8073584/webrev.01/
>>>
>>> Notes:
>>>
>>> I use an ugly trick: (void) (read() + 1) to get rid of ignored value
>>> warning because since gcc 4.6 just (void) is not enough.
>> Why not just check the return value for correctness?
>>
>> David
>>
>>> -Dmitry
>>>
>>>
>




More information about the core-libs-dev mailing list