RFR: 8073394: Clock.systemUTC() should return a constant

[Daniel Fuchs]

On 23/02/15 21:40, Stephen Colebourne wrote:
> The rest of the java.time code tends to put the data provider method
> before the test, and mostly uses a naming convention of
> "data_systemClocks". Neither of which are particularly important
> things.

Thanks Stephen.

I had a look at TestLocalDate.java
<http://hg.openjdk.java.net/jdk9/dev/jdk/file/tip/test/java/time/test/java/time/TestLocalDate.java#l177>
and tried to emulate what I saw there. All files in that
directory seem to share the same convention.

Here is the new webrev:
http://cr.openjdk.java.net/~dfuchs/webrev_8073394/webrev.02/

best regards,

-- daniel

>
> Stephen
>
>
> On 23 February 2015 at 20:02, Daniel Fuchs <daniel.fuchs at oracle.com> wrote:
>> On 23/02/15 19:50, Roger Riggs wrote:
>>>
>>> Hi Daniel,
>>>
>>> Typically, a TestNG DataProvider would have been used to supply the case
>>> data
>>> instead of an internal Map.
>>
>>
>> Thanks Roger. I should take some time to learn more about TestNG.
>>
>> Here is the new webrev:
>>
>> http://cr.openjdk.java.net/~dfuchs/webrev_8073394/webrev.01/
>>
>> -- daniel
>>
>>
>>>
>>> The rest looks fine.
>>>
>>> Thanks, Roger
>>>
>>> On 2/23/2015 12:41 PM, Daniel Fuchs wrote:
>>>>
>>>> Hi,
>>>>
>>>> Please find below a small patch for
>>>> 8073394: Clock.systemUTC() should return a constant
>>>>
>>>> http://cr.openjdk.java.net/~dfuchs/webrev_8073394/webrev.00/
>>>>
>>>> best regards,
>>>>
>>>> -- daniel
>>>
>>>
>>