RFR JDK-8073893: Enable charsets build system to configure euc_tw into java.base module/sun.nio.cs

[Xueming Shen]

On 02/25/2015 12:14 PM, Alan Bateman wrote:
> On 25/02/2015 19:51, Xueming Shen wrote:
>> Hi, please help review the changes for
>>
>> issue: 8073893: Enable charsets build system to configure euc_tw into java.base module/sun.nio.cs
>> webrev: http://cr.openjdk.java.net/~sherman/8073893/webrev
>>
>> This is the continuation of JDK-8073152, in which we updated the build mechanism to be move
>> some sun.nio.cs.ext charsets from the jdk.charsets module into the java.base module. The
>> proposed change in this RFE is to do the same thing to enable the EUC_TW (huge, about
>> 200k) to be built into the java.base/sun.nio.cs as well, for Solaris platform.
>>
>> The change also includes a small update to move the x-COMPOUND_TEXT into the configure
>> file for the extended charsets provider, in stead of being hard-coded in the source file.
> This looks good to me and I don't think the static footprint size on Solaris is a big issue.
>
> Were there copyright headers missing from the gensrc, just wondering about the change to Gensrc-jdk.charsets.gmk.

Thanks!

Yes, those copyright headers were missing in my last change for those hkscs.

-Sherman