RFR(S): 8073497: Lazy conversion of ZipEntry time

Claes Redestad claes.redestad at oracle.com
Fri Feb 27 16:32:50 UTC 2015


On 02/26/2015 10:09 PM, Peter Levart wrote:
>
> Hi Claes,
>
> I like the backwards-compatible extended DOS time format idea. If you 
> keep it as one field, you could move the code for conversion from 
> millisecond Java time to/from extended DOS time format to the ZipUtils 
> methods entirely (javaToXdosTime, xdosToJavaTime) to make logic in 
> ZipEntry simpler. I would call the field 'xdostime' then to hint the 
> reader about the format which would be nice if it was described in a 
> javadoc on the field.
>
> Regards, Peter

Something like this, then:

http://cr.openjdk.java.net/~redestad/jdk9/8073497/webrev.5

Thanks!

/Claes



More information about the core-libs-dev mailing list