RFR 8061297 : sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem

Mandy Chung mandy.chung at oracle.com
Wed Jan 14 16:03:08 UTC 2015


On 1/14/2015 5:55 AM, Chris Hegarty wrote:
> This test currently completes successfully, but indicates that it has 
> "Parsed 0 classfiles". It doesn't do anything useful.
>
> The modular image no longer contains jar files. The test should use 
> the JRT FileSystem to iterate over the image classfiles.
>
> http://cr.openjdk.java.net/~chegar/8061297/webrev.00/webrev/

Thanks for taking this on.  This looks okay.

line 196: checking if $JAVA_HOME/lib doesn't seem necessary as the 
current runtime is valid, otherwise it won't startup.

It may be good to change getClasses() to return Stream<Path>. As Paul 
points out the thread-safe issue, csMethodsMissingAnnotation should be 
CopyOnWriteArrayList.

Mandy



More information about the core-libs-dev mailing list