RFR 8061297 : sun/reflect/CallerSensitive/CallerSensitiveFinder.java should use the JRT FileSystem

Mandy Chung mandy.chung at oracle.com
Wed Jan 14 21:51:20 UTC 2015


On 1/14/2015 8:31 AM, Chris Hegarty wrote:
> On 14/01/15 16:18, Mandy Chung wrote:
>> On 1/14/2015 8:04 AM, Chris Hegarty wrote:
>>>
>>> http://cr.openjdk.java.net/~chegar/8061297/webrev.01/webrev/
>>
>> Looks okay to me.
>>
>> In CallerSensitiveFinder.java line 57, 80, 137 - not sure if you were
>> thinking to pass "pool" to the CallerSensitiveFinder constructor. Looks
>> like some editing you meant to cleanup.
>>
>>    nit: line 76 a space between "classes" and "=="
>>    line 207 can be removed.
>
> D'oh! Fixed both of these. Webrev updated in place.

Thumbs up.

Mandy



More information about the core-libs-dev mailing list