JDK 9 RFR of 8060077: Class.toGenericString specification doesn't mention array types

Joel Borggrén-Franck joel.franck at oracle.com
Thu Jan 15 13:53:10 UTC 2015


Hi Joe,

Nits,

 152      * "void". If this {@code Class} object presents an array type,
 153      * this method returns "class " followed by {@code getName}.

line 152, presents or represents?

Personally I would add a test for a 2-dim array of a generic type.

cheers
/Joel

> On 15 jan 2015, at 02:03, joe darcy <joe.darcy at oracle.com> wrote:
> 
> Hello,
> 
> Please review these changes to address
> 
>    JDK-8060077 : Class.toGenericString specification doesn't mention array types
>    http://cr.openjdk.java.net/~darcy/8060077.0/
> 
> Thanks,
> 
> -Joe
> 




More information about the core-libs-dev mailing list