RFR 8067748: (process) Child is terminated when parent's console is closed [win]

Ivan Gerasimov ivan.gerasimov at oracle.com
Fri Jan 23 08:10:55 UTC 2015


Thank you Alan!

On 22.01.2015 21:12, Alan Bateman wrote:
> On 22/01/2015 14:37, Ivan Gerasimov wrote:
>> :
>> It's hard to create a test, which involves closing the console window 
>> and manipulating the detached child application.
>>
>> Would you please help review the fix?
>>
>> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8067748
>> WEBREV: http://cr.openjdk.java.net/~igerasim/8067748/0/webrev/
> Yet again, the Process code bites back :-)
>
Yes. I remember you warned about that :-)

> I think this looks okay and we should probably have looked at redirect 
> and inheritance more when discussing the console window pop-up issue.
> I don't personally like references to bug numbers in comments, others 
> will have different opinions.

Okay I removed the reference.  I agree that it can easily be found in 
the hg history anyway.

> You have a good case for noreg-hard as it's not clear that it would be 
> easy to create an automated test for this.
>
I'll provide the textual instructions for the SQE in the comments to the 
bug.


Sincerely yours,
Ivan



More information about the core-libs-dev mailing list