RFR: 8062923: XSL: Run-time internal error in 'substring()'

[huizhe wang]

Hi Aleksej,

Looks good. There is a minor format issue at line 299.

Note that, for JDK 9, we now have functional/unit tests under jaxp/test. 
This test would fix in javax/xml/jaxp/unittest/javax/xml/transform. For 
test format, please take a look at a functional test 
(javax/xml/jaxp/functional) since Tristan has refactored them, and SQE 
plans to do the same with the unit tests.  For a testng test, the @run 
tag is not necessary.

The jaxp tests are defined in its own testset "jaxp".

Thanks,
Joe

On 1/19/2015 3:25 AM, Aleksej Efimov wrote:
> Hi,
>
> Please, review the fix for the XSL substring function failures. Two 
> issues were reported during usage of this function:
> 1. Runtime internal error with negative length: 
> https://bugs.openjdk.java.net/browse/JDK-8062923
> 2. Wrong answer when -Inf length is used: 
> https://bugs.openjdk.java.net/browse/JDK-8062924
>
> These two issues can be solved by fix proposed for the review: 
> http://cr.openjdk.java.net/~aefimov/8062923/webrev.00
>
> Testing:
> xml related regression tests (with new test) - no failures (from jdk 
> and jaxp repos).
> JCK xml related tests - no failures.
>
> With Best Regards,
> Aleksej