[9] RFR of 6880737: (fs) FileLock constructors don't throw NPE if the channel argument is null

Brian Burkhalter brian.burkhalter at oracle.com
Fri Jan 23 19:17:01 UTC 2015


On Jan 16, 2015, at 11:33 PM, Alan Bateman <Alan.Bateman at oracle.com> wrote:

> The change to the javadoc isn't strictly required as there is a general statement in the package description that NPE be thrown when methods or constructors are called with null.

Thanks, I missed that.

> So the implementation should throw NPE rather than IAE and as it's an incompatible change then it should be tracked. It's important to add a test case too.


Here’s an updated patch including a (perhaps overkill) test:

http://cr.openjdk.java.net/~bpb/6880737/webrev.01/

Thanks,

Brian


More information about the core-libs-dev mailing list