RFR: 8046817: JDK 8 schemagen tool does not generate xsd files for enum types

huizhe wang huizhe.wang at oracle.com
Fri Jan 23 21:18:11 UTC 2015


Looks good, Aleksej.

Thanks,
Joe

On 1/19/2015 8:48 AM, Aleksej Efimov wrote:
> Hi,
> Returning back to this issue: The fix will be integrated soon to 
> standalone JAXB project. Local build of standalone JAXB succeeded. No 
> issues with jaxb tests were observed with applied fix.
> Can I ask reviewers to look at this issue now?
>
> Thank you and Best Regards,
> Aleksej
>
> On 10/15/2014 03:08 PM, Miroslav Kos wrote:
>> Hi Aleksej,
>>
>> the change looks ok to me, but it would be good to integrate it into 
>> upstream (standalone JAX-B RI project) first to be on safe side - 
>> there are much more tests then in OpenJDK.
>>
>> Copying Iaroslav who is JAX-B RI lead and can help you with 
>> integration and running tests.
>>
>> Thanks
>> Miran
>>
>>
>> On 14/10/14 09:29, Aleksej Efimov wrote:
>>> Hi XML experts,
>>> Can I humbly ask  to review this simple fix.
>>>
>>> Thank you,
>>> Aleksej
>>>
>>> On 08.10.2014 13:09, Aleksej Efimov wrote:
>>>> Hello,
>>>>
>>>> Please, review the fix [1] for the 8046817 [2].
>>>> Problem: schemagen tool doesn't generate schema file for the enum 
>>>> types [3].
>>>> SchemaGenerator class gets a list of annotated elements and filters 
>>>> out only the class variables, but annotation parser 
>>>> (AnnotationParser.java) filters out the Class and Enum. The 
>>>> proposed fix solves the problem: SchemaGenerator filters like 
>>>> AnnotationParser.
>>>> Testing: JPRT build and test passes on platforms (with new 
>>>> regression test). JTREG tests: javax/xml - no failures.
>>>>
>>>> Thanks,
>>>> Aleksej
>>>>
>>>> [1] Webrev: http://cr.openjdk.java.net/~aefimov/8046817/9/webrev.00/
>>>> [2] Bug: https://bugs.openjdk.java.net/browse/JDK-8046817
>>>> [3] Enum type: 
>>>> http://cr.openjdk.java.net/~aefimov/8046817/9/webrev.00/jdk/test/javax/xml/ws/8046817/TestEnumType.java.html
>>>
>>
>




More information about the core-libs-dev mailing list