RFR 9: 8068578: test/java/io/Serializable/subclassGC/SubclassGC.java assumes app class loader is a URLClassLoader

Alan Bateman Alan.Bateman at oracle.com
Sat Jan 24 08:57:16 UTC 2015


On 24/01/2015 00:15, Brent Christian wrote:
> Hi,
>
> Please review this test case update.
>
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8068578
> Webrev:
> http://cr.openjdk.java.net/~bchristi/8068578/webrev.0/
>
> The test relies on creating a new URLClassLoader and using it to load 
> a subclass of ObjectOutputStream.  The system classloader is cast to a 
> URLClassLoader in order to call getURLs(), but the test can be made to 
> work without this URL[].  We can instead create a URL based on the 
> value of the "test.classes" system property.
>
> I have confirmed that the test still detects the original bug 
> (6232010) in 5u6, and passes with later JDKs.
It's good to have this assumption removed from the test. The change 
looks okay to me and thanks for confirming the original issue.

-Alan



More information about the core-libs-dev mailing list