Review request for JDK-8051709: Convert JAXP function tests: javax.xml.datatype to jtreg (testng) tests

[Lance Andersen]

Hi Frank,

I think this looks good. 


Not sure if you are going to add more tests in the future, but would be good to have tests such as

new Duration(x.toString()).equals(x)


Perhaps a few more checks on expected toString() output….


For XMLGregorianCalendarTest.java,  I would consider at some point adding more permutations of some of the tests that are validating a bugs(now that you are adding this as a new test suite to openjdk)


Best
Lance

On Jan 26, 2015, at 1:42 AM, Frank Yuan <frank.yuan at oracle.com> wrote:

> Hi, Joe and All
> 
> We are working on moving internal jaxp functional tests to open jdk repo.
> This is the datatype suite. Would you please review these test?  Any comment
> will be appreciated.
> 
> bug: https://bugs.openjdk.java.net/browse/JDK-8051709
> webrev: http://cr.openjdk.java.net/~fyuan/8051709/webrev.00/
> 
> 
> Thanks,
> 
> Frank
> 



Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com