Review request for JDK-8051547: Convert JAXP function tests: javax.xml.validation.* to jtreg (testng) tests
huizhe wang
huizhe.wang at oracle.com
Thu Jan 29 05:42:02 UTC 2015
I see, it's all good then.
Joe
On 1/28/2015 6:17 PM, Frank Yuan wrote:
>
> Actually, Schema01 is commented out from TestValidation.java although
> Schema01.java exists in sqe repo.
>
> Best Regards
>
> Frank
>
> *From:*huizhe wang [mailto:huizhe.wang at oracle.com]
> *Sent:* Thursday, January 29, 2015 7:34 AM
> *To:* Frank Yuan
> *Cc:* 'Lance Andersen'; 'Core-Libs-Dev'; 'Gustavo Galimberti'
> *Subject:* Re: Review request for JDK-8051547: Convert JAXP function
> tests: javax.xml.validation.* to jtreg (testng) tests
>
> Hi Frank,
>
> I noticed that the test "Schema01" is not in the webrev. Did you
> remove it? It's not a problem since what the two test cases did were
> covered by the Validator/ValidatorHandler tests. So, just wanted to
> make sure.
>
> Thanks,
> Joe
>
> On 1/28/2015 2:57 AM, Frank Yuan wrote:
>
> Thank you!
>
> Then would you like to be the sponsor for this code change?
>
> Best Regards
>
> Frank
>
> *From:*Lance Andersen [mailto:lance.andersen at oracle.com]
> *Sent:* Tuesday, January 27, 2015 5:08 AM
> *To:* Frank Yuan
> *Cc:* 'huizhe wang'; 'Core-Libs-Dev'; 'Gustavo Galimberti'
> *Subject:* Re: Review request for JDK-8051547: Convert JAXP
> function tests: javax.xml.validation.* to jtreg (testng) tests
>
> Hi Frank,
>
> This looks pretty good overall.
>
> Best
>
> Lance
>
> On Jan 25, 2015, at 10:27 PM, Frank Yuan <frank.yuan at oracle.com
> <mailto:frank.yuan at oracle.com>> wrote:
>
>
>
>
> Hi, Joe and All
>
> We are working on moving internal jaxp functional tests to
> open jdk repo.
> This is the validation suite. Would you please review these
> test? Any
> comment will be appreciated.
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8051547
> webrev: http://cr.openjdk.java.net/~fyuan/8051547/webrev.00/
> <http://cr.openjdk.java.net/%7Efyuan/8051547/webrev.00/>
>
>
> Thanks,
>
> Frank
>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>
>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance
> Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>
>
>
>
More information about the core-libs-dev
mailing list