JDK 9 RFR of JDK-8071434: doc updates for java.lang.Object

Roger Riggs Roger.Riggs at Oracle.com
Thu Jan 29 21:03:57 UTC 2015


Hi Joe,

Looks fine (though I don't have the books to verify the references).

Roger

On 1/29/2015 3:53 PM, joe darcy wrote:
> Hello,
>
> Please review a few doc updates for java.lang.Object:
>
>      JDK-8071434: doc updates for java.lang.Object
>     http://cr.openjdk.java.net/~darcy/8071434.0/
>
> Patch below.
>
> Thanks,
>
> -Joe
>
> --- old/src/java.base/share/classes/java/lang/Object.java 2015-01-29 
> 12:50:41.099429597 -0800
> +++ new/src/java.base/share/classes/java/lang/Object.java 2015-01-29 
> 12:50:40.771265589 -0800
> @@ -1,5 +1,5 @@
>  /*
> - * Copyright (c) 1994, 2012, Oracle and/or its affiliates. All rights 
> reserved.
> + * Copyright (c) 1994, 2015, Oracle and/or its affiliates. All rights 
> reserved.
>   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>   *
>   * This code is free software; you can redistribute it and/or modify it
> @@ -86,12 +86,11 @@
>       *     for unequal objects may improve the performance of hash 
> tables.
>       * </ul>
>       * <p>
> -     * As much as is reasonably practical, the hashCode method 
> defined by
> -     * class {@code Object} does return distinct integers for distinct
> -     * objects. (This is typically implemented by converting the 
> internal
> -     * address of the object into an integer, but this implementation
> -     * technique is not required by the
> -     * Java™ programming language.)
> +     * As much as is reasonably practical, the hashCode method defined
> +     * by class {@code Object} does return distinct integers for
> +     * distinct objects. (The hashCode may or may not be implemented
> +     * as some function of an object's memory address at some point
> +     * in time.)
>       *
>       * @return  a hash code value for this object.
>       * @see     java.lang.Object#equals(java.lang.Object)
> @@ -344,10 +343,11 @@
>       *         ... // Perform action appropriate to condition
>       *     }
>       * </pre>
> -     * (For more information on this topic, see Section 3.2.3 in Doug 
> Lea's
> -     * "Concurrent Programming in Java (Second Edition)" 
> (Addison-Wesley,
> -     * 2000), or Item 50 in Joshua Bloch's "Effective Java Programming
> -     * Language Guide" (Addison-Wesley, 2001).
> +     *
> +     * (For more information on this topic, see section 14.2,
> +     * Condition Queues, in Brian Goetz and others'"Java Concurrency in
> +     * Practice" (Addison-Wesley, 2006) or Item 69 in Joshua Bloch's
> +     * "Effective Java (Second Edition)" (Addison-Wesley, 2008).
>       *
>       * <p>If the current thread is {@linkplain 
> java.lang.Thread#interrupt()
>       * interrupted} by any thread before or while it is waiting, then an
>




More information about the core-libs-dev mailing list