RFR 8/9: 8068278 ArrayIndexOutOfBoundsException instead of DateTimeException in j.t.chrono.JapaneseChronology.eraOf()
Mandy Chung
mandy.chung at oracle.com
Fri Jan 30 23:48:09 UTC 2015
On 1/30/15 2:33 PM, Roger Riggs wrote:
> Hi Mandy,
>
> Thanks for the review.
>
> I wrote the test (and it passed) but since the JCK folks are providing
> the tests it seemed
> undesirable to have duplicate tests.
JDK developers don't run JCK tests and I think it'd be nice to have a
regression test to go with a fix unless the bug is uncovered by an
existing test.
Mandy
>
> Roger
>
> On 1/30/2015 5:27 PM, Mandy Chung wrote:
>> On 1/30/15 2:25 PM, Roger Riggs wrote:
>>> Please review this correction of a JapaneseEra range check in
>>> java.time.
>>> The error was discovered during development of additional
>>> conformance tests (to be delivered separately).
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~rriggs//webrev-era-8068278
>>>
>>
>> Looks fine to me. Is it easy to write a regression test to go along
>> with this fix?
>>
>> Mandy
>>
>>> Issue:
>>> <https://bugs.openjdk.java.net/browse/JDK-8068278> 8068278
>>> ArrayIndexOutOfBoundsException instead of DateTimeException in
>>> j.t.chrono.JapaneseChronology.eraOf()
>>>
>>> Thanks, Roger
>>>
>>
>
More information about the core-libs-dev
mailing list