8058779: Faster implementation of String.replace(CharSequence, CharSequence)

Ivan Gerasimov ivan.gerasimov at oracle.com
Mon Jun 1 18:53:26 UTC 2015



On 01.06.2015 11:33, Paul Sandoz wrote:
> On May 31, 2015, at 6:03 PM, Ivan Gerasimov <ivan.gerasimov at oracle.com> wrote:
>> Which is right here:
>> http://cr.openjdk.java.net/~igerasim/8058779/05/webrev/
>>
> Much better.
>
> For the test can you use RandomFactory recently added to the test library?

Sure.
Here the updated webrev with this change and a few other minor changes.
http://cr.openjdk.java.net/~igerasim/8058779/06/webrev/

The changes are:
- move declaration of i below,
- indent .append(),
- use RandomFactory in the test,
- extend number of test cases with null input.

Do you think it's ready to go?

Sincerely yours,
Ivan

> Paul.
>
>
>




More information about the core-libs-dev mailing list