8058779: Faster implementation of String.replace(CharSequence, CharSequence)

[Ivan Gerasimov]

On 01.06.2015 22:10, Xueming Shen wrote:
> Ivan,
>
> The code looks fine for me.
>
> Just wonder what's the motivation of using the newStringUnsafe() in 
> the test case. Simply
> to save the char[] copy to speed up the test? I don't think we really 
> care about it here,
> right?
>
Yes, right. I'll replace it with new String(char[]).

Sincerely yours,
Ivan

> -Sherman
>
> On 06/01/2015 11:53 AM, Ivan Gerasimov wrote:
>>
>>
>> On 01.06.2015 11:33, Paul Sandoz wrote:
>>> On May 31, 2015, at 6:03 PM, Ivan Gerasimov 
>>> <ivan.gerasimov at oracle.com> wrote:
>>>> Which is right here:
>>>> http://cr.openjdk.java.net/~igerasim/8058779/05/webrev/
>>>>
>>> Much better.
>>>
>>> For the test can you use RandomFactory recently added to the test 
>>> library?
>>
>> Sure.
>> Here the updated webrev with this change and a few other minor changes.
>> http://cr.openjdk.java.net/~igerasim/8058779/06/webrev/
>>
>> The changes are:
>> - move declaration of i below,
>> - indent .append(),
>> - use RandomFactory in the test,
>> - extend number of test cases with null input.
>>
>> Do you think it's ready to go?
>>
>> Sincerely yours,
>> Ivan
>>
>>> Paul.
>>>
>>>
>>>
>>
>
>
>