[8u-dev] Review request : JDK-8062904: TEST_BUG: Tests java/lang/invoke/LFCaching fail when run with -Xcomp option

Vladimir Ivanov vladimir.x.ivanov at oracle.com
Fri Jun 5 10:16:51 UTC 2015


Konstantin,

> The test has the code cache overflow failure only when run with
> "-Xcomp", all other failures has been fixed by
> https://bugs.openjdk.java.net/browse/JDK-8058733
> So my suggestion is either to exclude this test when run with -Xcomp or
> (better) to reduce iteration number to 1 when -Xcomp, so that no code
> cache overflow in this case.
I'd like to get an answer to my previous question:
"How reliable the test is if it ignores NoSuchMethodException & 
VirtualMachineError? Are there other manifestations of the problem?"

Most notably, have you seen VM crashes w/ -Xcomp running that test?

Best regards,
Vladimir Ivanov

>
> -Konstantin
>
>>
>> Best regards,
>> Vladimir Ivanov
>>
>>>
>>> -Konstantin
>>>
>>> On 29.05.2015 14:49, Vladimir Ivanov wrote:
>>>>> What do you mean by ignore code cache overflow? Do you mean I
>>>>> should fix
>>>>> the test to ignore these errors or should I leave this test unfixed
>>>>> because it is a product related issue?
>>>> The former. How reliable the test is if it ignores
>>>> NoSuchMethodException & VirtualMachineError? Are there other
>>>> manifestations of the problem?
>>>>
>>>> Best regards,
>>>> Vladimir Ivanov
>>>>
>>>>> On 28.05.2015 21:22, Vladimir Ivanov wrote:
>>>>>> Got it, thanks.
>>>>>>
>>>>>> Can we ignore errors caused by code cache overflow for now?
>>>>>>
>>>>>> Best regards,
>>>>>> Vladimir Ivanov
>>>>>>
>>>>>> On 5/28/15 12:03 PM, Konstantin Shefov wrote:
>>>>>>> Vladimir,
>>>>>>>
>>>>>>> This fix is not for timeout issue, this fix is for
>>>>>>> "java.lang.VirtualMachineError: out of space in CodeCache for
>>>>>>> adapters".
>>>>>>>
>>>>>>> Timeout issue is other bug and should be filed separately.
>>>>>>> I do not know why SQE added RULES with timeout to this bug.
>>>>>>>
>>>>>>> By the way, if -Xcomp is set on JDK 8u, test works if not more than
>>>>>>> one
>>>>>>> iteration is allowed. The same thing was for JDK 9 until
>>>>>>> JDK-8046809 had
>>>>>>> been fixed.
>>>>>>>
>>>>>>> -Konstantin
>>>>>>>
>>>>>>> On 27.05.2015 19:54, Vladimir Ivanov wrote:
>>>>>>>> Have you tried to reduce iteration granularity?
>>>>>>>>
>>>>>>>> Probably, checking execution duration on every test case is more
>>>>>>>> robust.
>>>>>>>>
>>>>>>>> Best regards,
>>>>>>>> Vladimir Ivanov
>>>>>>>>
>>>>>>>> On 5/27/15 5:50 PM, Konstantin Shefov wrote:
>>>>>>>>> Hello,
>>>>>>>>>
>>>>>>>>> Please review the test bug fix
>>>>>>>>> https://bugs.openjdk.java.net/browse/JDK-8062904
>>>>>>>>> Webrev is http://cr.openjdk.java.net/~kshefov/8062904/webrev.01/
>>>>>>>>> Test fails only against JDK 8u and passes against JDK 9.
>>>>>>>>>
>>>>>>>>> Thanks
>>>>>>>>>
>>>>>>>>> -Konstantin
>>>>>>>
>>>>>
>>>
>



More information about the core-libs-dev mailing list