RFR [9] 8081517: minor cleanup for docs

[Roger Riggs]

Hi Alexander,

Looks good, thanks for the updates.

Roger


On 6/5/2015 1:33 PM, alexander stepanov wrote:
> Hello Lance, Roger,
>
> Thank you for the notes, please see the updated webrev:
> http://cr.openjdk.java.net/~avstepan/8081517/webrev.01/index.html
> (files changed: FtpURLConnection.java, VmIdentifier.java, 
> TraceClassVisitor.java, HttpAuthenticator.java, PlatformLogger.java 
> and JdbcRowSetImpl.java - some indents were fixed)
>
> > SQL AS clause
> that's probably used for the SQL "AS" keyword. In such a case the 
> upper case may be suitable.
>
> Regards,
> Alexander
>
>
> On 05.06.2015 17:12, Lance Andersen wrote:
>> Hi Roger
>> On Jun 5, 2015, at 10:08 AM, Roger Riggs <Roger.Riggs at oracle.com> wrote:
>>
>>> 2)
>>> If indentation is in the scope of your cleanup…
>> Agree with you and I did not comment on this as I felt it this should 
>> be done separately as there is a fair amount that can be done in 
>> these classes for clean up.
>>
>> Best
>> lance
>>>
>>> In JdbcRowSetImpl.java, the indentation of continued lines after 
>>> @return or @param tags
>>> isn't correct; the continued line should be indented.
>>>
>>> And there are a some very long lines that should be wrapped;
>>> See +5637...   "If the SQL AS clause was not..."
>>>
>>> +5784 the indentation needs to be fixed.
>>> +5840 also
>>> +5988
>>> +6265 and after...
>>>   in many cases the lines that follow of "/*" do not align the "* ".
>>>
>>> CachedRowSetWriter.java:
>>> - many method comment blocks are not aligned properly with the 
>>> method of field that follows.
>>> For example,
>>> /**
>>> * The <code>Connection</code> object that this writer will use to 
>>> make a
>>> * connection to the data source to which it will write data.
>>> *
>>> */
>>>     private transient Connection con;
>>>
>>> 3)
>>>
>>> CachedRowSetWriter.java:
>>> +1056:  The tag "@ param" should be tighted up to "@param"
>>>
>>> Thanks, Roger
>>>
>>>
>>>
>>> On 6/5/2015 8:51 AM, alexander stepanov wrote:
>>>> Hello,
>>>>
>>>> Could you please review the fix
>>>> http://cr.openjdk.java.net/~avstepan/8081517/webrev.00/
>>>> for
>>>> https://bugs.openjdk.java.net/browse/JDK-8081517
>>>>
>>>> Just some cleanup for docs.
>>>>
>>>> Thanks,
>>>> Alexander
>>
>>
>> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>> Oracle Java Engineering
>> 1 Network Drive
>> Burlington, MA 01803
>> Lance.Andersen at oracle.com
>>
>>
>>
>