[9] Review request : JDK-8062904: TEST_BUG: Tests java/lang/invoke/LFCaching fail when run with -Xcomp option

Konstantin Shefov konstantin.shefov at oracle.com
Wed Jun 17 16:21:59 UTC 2015


Vladimir

I have updated the webrev: 
http://cr.openjdk.java.net/~kshefov/8062904/webrev.04/

-Konstantin

On 06/17/2015 04:09 PM, Vladimir Ivanov wrote:
> Konstantin,
>
> Overall looks good w.r.t. my previous comments about Utils class.
>
> You have a duplicate of processVME in LambdaFormTestCase.
>
> Best regards,
> Vladimir Ivanov
>
> On 6/17/15 1:21 PM, Konstantin Shefov wrote:
>> Hello,
>>
>> I have updated the fix once more
>> http://cr.openjdk.java.net/~kshefov/8062904/webrev.03/
>>
>> Please, review
>>
>> Thanks
>> -Konstantin
>>
>> On 06/16/2015 02:01 PM, Konstantin Shefov wrote:
>>> Hello,
>>>
>>> Please, review the new version of the fix to this issue
>>> http://cr.openjdk.java.net/~kshefov/8062904/webrev.02/
>>>
>>> Here it is suggested to catch all exceptions caused by
>>> VirtualmachineException with "Out of CodeCache" message and stop
>>> iterations and consider the test as passed if no other exceptions is
>>> thrown.
>>>
>>> -Konstantin
>>>
>>> On 11/07/2014 01:28 PM, Igor Ignatyev wrote:
>>>> Ho Konstantin,
>>>>
>>>> Actually, I don't think that this should be fixed by reducing
>>>> iterations, CompileCommand magic sounds more reasonable here.
>>>>
>>>> I'd even say I'm not sure that it's a test bug, it looks very similar
>>>> to JDK-8046809. have you tried to run the tests on the build where
>>>> JDK-8046809 is fixed?
>>>>
>>>> Igor
>>>>
>>>> On 11/06/2014 06:20 PM, Konstantin Shefov wrote:
>>>>> Igor,
>>>>>
>>>>> Thanks for your comment!
>>>>> Here is the updated webrev:
>>>>> http://cr.openjdk.java.net/~kshefov/8062904/webrev.01/
>>>>>
>>>>> -Konstantin
>>>>>
>>>>> On 06.11.2014 17:36, Igor Ignatyev wrote:
>>>>>> Konstantin,
>>>>>>
>>>>>> please use 'java.vm.info' instead of iteration over flags.
>>>>>>
>>>>>> Igor
>>>>>>
>>>>>> On 11/06/2014 01:44 PM, Konstantin Shefov wrote:
>>>>>>> Hello,
>>>>>>>
>>>>>>> Please review the test bug fix
>>>>>>> https://bugs.openjdk.java.net/browse/JDK-8062904
>>>>>>> Webrev is http://cr.openjdk.java.net/~kshefov/8062904/webrev.00/
>>>>>>>
>>>>>>> Thanks
>>>>>>>
>>>>>>> -Konstantin
>>>>>
>>>
>>




More information about the core-libs-dev mailing list