RFR 9: 8129535: java_props_md.c should compile on VS 2010
Roger Riggs
Roger.Riggs at Oracle.com
Tue Jun 23 13:20:43 UTC 2015
Hi Alan,
Dropping VS2010 should probably a deliberate choice/state, not just an
oversight in coding.
Its also a style question, if this were shared code I think Solaris also
complains about
inline declarations; but that too may be due to an older tool chain.
Thanks, Roger
On 6/23/2015 2:42 AM, Alan Bateman wrote:
> On 23/06/2015 04:50, Roger Riggs wrote:
>> Please review a minor correction so java_props_md.c will compile with
>> Visual Studio 2010.
>> (Declarations are allowed in the middle of blocks only in later
>> versions).
>>
>> Webrev:
>> http://cr.openjdk.java.net/~rriggs/webrev-props-vs1010-8129535/
>>
>> Issue:
>> https://bugs.openjdk.java.net/browse/JDK-8129535
> This looks okay to me although not clear how long this should continue
> to build with VS2010. There is probably a compiler option for this too.
>
> -Alan
More information about the core-libs-dev
mailing list