RFR 9: 8129535: java_props_md.c should compile on VS 2010

[Volker Simonis]

Hi Roger,

thanks for doing this change! I already had this on my list as well as
we at SAP are also still using VS2010 - and probably will use it for
quite some time :(

The bug was actually a C99 feature which isn't supported by the
C-compiler of VS2010 (see
http://herbsutter.com/2012/05/03/reader-qa-what-about-vc-and-c99/ for
a discussion why) and even though the official Windows compiler was
upgraded to VS2013 I don't think we've explicitly upgraded the code
base to C99 (or I must have missed that).

Regards,
Volker


On Tue, Jun 23, 2015 at 3:32 PM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
>
> On 23/06/2015 14:20, Roger Riggs wrote:
>>
>> Hi Alan,
>>
>> Dropping VS2010 should probably a deliberate choice/state, not just an
>> oversight in coding.
>> Its also a style question, if this were shared code I think Solaris also
>> complains about
>> inline declarations; but that too may be due to an older tool chain.
>
> Sure but my point is that the JDK 9 moved to VS2013 a few months ago so over
> time then I assume fewer people will be building with VS2010 to see issues
> like this.
>
> -Alan