RFR 8124977 cmdline encoding challenges on Windows

Kirk Shoop (MS OPEN TECH) Kirk.Shoop at microsoft.com
Tue Jun 23 20:31:03 UTC 2015


> From: Martin Buchholz [mailto:martinrb at google.com]
> "default unicode charset" is a bizarre concept to me.  Do windows users really have a "regular" charset and a "unicode" charset?  If they do, we probably want to keep that concept out of the public non-Windows API somehow.  Also, the "W" API is implicitly UTF-16, not any other flavor of Unicode.  You probably want to capitalize "unicode".

The defaultUnicodeCharset is not a windows concept. This is the way we chose to ensure that the previous charset selection in the openJDK was unchanged unless windows.UnicodeConsole == true and that all the places that needed to override the charset on windows were covered by one new parameter. 

We could change the implementation such that the existing sun.jnu.encoding and file.encoding properties were used instead of adding the new file.encoding.unicode property. This might require that users set both on the commandline instead of just one. 
Other ideas for how to safely modify the charset selection when  windows.UnicodeConsole == true are welcome.

Thanks,
Kirk

Developer
Microsoft Open Technologies, Inc.


More information about the core-libs-dev mailing list