RFR: JDK-8080679: Include jline in JDK for Java and JavaScript REPLs
Alan Bateman
Alan.Bateman at oracle.com
Fri Jun 26 14:00:35 UTC 2015
On 26/06/2015 14:38, Jan Lahoda wrote:
> Uploaded a new iteration of the patch, reflecting the comments so far,
> here:
> http://cr.openjdk.java.net/~jlahoda/8080679/webrev.02/full/
>
> A delta patch from previous iteration:
> http://cr.openjdk.java.net/~jlahoda/8080679/webrev.02/delta/
>
> Any feedback on this would be appreciated!
>
> Thanks for the comments!
>
This looks okay although you might consider moving the initialization to
a initIDs (or some such method) that is called after the
System.loadLibrary. You'll see many examples of this already in the JDK.
-Alan.
More information about the core-libs-dev
mailing list