RFR: 8130051 Cleanup usage of reflection in jaxp

huizhe wang huizhe.wang at oracle.com
Mon Jun 29 22:52:14 UTC 2015


Hi Daniel,

Another great cleanup!  The change looks good to me. Only minor 
suggestion: same as 8129956, would you want to add the types back 
instead of using diamond operator? It looks good, but the red flags in 
the NetBeans could be a bit troublesome. Plus, honestly, I still 
regularly compile jaxp-only using JDK 8 for a quick turnaround. Using 
JDK 8 makes it easier to compare with results from JDK8 as we work on 
regressions and etc.

Thanks,
Joe

On 6/29/2015 4:17 AM, Daniel Fuchs wrote:
> Hi,
>
> Please find below a patch that cleans up some of the
> reflection usage in jaxp.
> https://bugs.openjdk.java.net/browse/JDK-8130051
>
> http://cr.openjdk.java.net/~dfuchs/webrev_8130051/webrev.00/
>
> This is not a deep cleanup - it is just a first pass...
> There may be some opportunity to get rid of some more
> obsolete code - which can be addressed by followup
> bugs/RFE (such as JDK-8129892).
>
> I also took this opportunity to remove two files which
> are not used in the JDK.
>
> jaxp/test, jdk/test/javax/xml/jaxp, and JCK test suites
> (api/javax_xml api/xinclude api/xsl xml_schema) passed.
>
> best regards,
>
> -- daniel
>
>
>
>




More information about the core-libs-dev mailing list