RFR(S): JDK-8073584 Native compilation warning in unpack code

[David Holmes]

On 10/03/2015 5:53 PM, Dmitry Samersoff wrote:
> David at all,
>
> May I consider the fix as reviewed and continue with integration?

Seems okay to me.

David

> -Dmitry
>
>
> On 2015-02-24 05:23, David Holmes wrote:
>> On 24/02/2015 12:02 AM, Dmitry Samersoff wrote:
>>> Hi Everyone,
>>>
>>> Webrev updated in-place (press shift-reload)
>>>
>>> http://cr.openjdk.java.net/~dsamersoff/JDK-8073584/webrev.01/
>>
>> share/native/libunpack/jni.cpp
>>
>> 295     return (jobject) NULL;
>>
>> Why do you need a cast on NULL?
>>
>>> Updated formatting.
>>>
>>> Hack in main.cpp replaced with true error check.
>>
>> Not sure it is appropriate to lump the "res != 1" in with the CR error.
>> Doesn't this case deserve its own u.abort(xxx) ?
>>
>> Thanks,
>> David
>>
>>> -Dmitry
>>>
>>>
>>> On 2015-02-23 05:07, David Holmes wrote:
>>>> On 21/02/2015 4:27 AM, Dmitry Samersoff wrote:
>>>>> Hi Everyone,
>>>>>
>>>>> It's my $0.02 to the warning cleanup work. Please review:
>>>>>
>>>>> http://cr.openjdk.java.net/~dsamersoff/JDK-8073584/webrev.01/
>>>>>
>>>>> Notes:
>>>>>
>>>>> I use an ugly trick: (void) (read() + 1) to get rid of ignored value
>>>>> warning because since gcc 4.6 just (void) is not enough.
>>>>
>>>> Why not just check the return value for correctness?
>>>>
>>>> David
>>>>
>>>>>
>>>>> -Dmitry
>>>>>
>>>>>
>>>
>>>
>
>