JDK 9 RFR of adding javadoc to the serialver tool class

[Lance Andersen]

looks ok joe
On Mar 13, 2015, at 1:40 PM, joe darcy <joe.darcy at oracle.com> wrote:

> Hello,
> 
> To support stricter doclint checking for the jdk.compiler module (http://mail.openjdk.java.net/pipermail/build-dev/2015-March/014560.html), some javadoc needs to be added to a class for the serialver tool which is in the jdk repo. Patch below.
> 
> I'm not quite sure why serialver is the the jdk.compiler module, perhaps that is the least-bad alternative. A way to avoid adding javadoc here would be to adjust the package filter being used in the makefile. The current filter of
> 
>    Xdoclint/package:-com.sun.tools.*
> 
> has the advantage of checking any new packages that may come in the only excluding those known not to be of interest for such check.
> 
> Thanks,
> 
> -Joe
> 
> diff -r 4330ca0a31bb src/jdk.compiler/share/classes/sun/tools/serialver/SerialVer.java
> --- a/src/jdk.compiler/share/classes/sun/tools/serialver/SerialVer.java Thu Feb 12 12:56:48 2015 -0800
> +++ b/src/jdk.compiler/share/classes/sun/tools/serialver/SerialVer.java Fri Mar 13 10:34:59 2015 -0700
> @@ -1,5 +1,5 @@
> /*
> - * Copyright (c) 1996, 2014, Oracle and/or its affiliates. All rights reserved.
> + * Copyright (c) 1996, 2015, Oracle and/or its affiliates. All rights reserved.
>  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>  *
>  * This code is free software; you can redistribute it and/or modify it
> @@ -37,6 +37,9 @@
> import java.util.StringTokenizer;
> import sun.net.www.ParseUtil;
> 
> +/**
> + * Supporting class for the serialver tool.
> + */
> public class SerialVer {
> 
>     /*
> @@ -117,6 +120,10 @@
>         }
>     }
> 
> +    /**
> +     * Entry point for serialver tool.
> +     * @param args the arguments
> +     */
>     public static void main(String[] args) {
>         String envcp = null;
>         int i = 0;
> 



Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com