[9] RFR of 8073214: javadoc of Properties methods should specify NullPointerExceptions
Alan Bateman
Alan.Bateman at oracle.com
Sat Mar 14 07:04:30 UTC 2015
On 13/03/2015 20:40, Brian Burkhalter wrote:
> Please review at your convenience.
>
> Issue: https://bugs.openjdk.java.net/browse/JDK-8073214
> Patch: http://cr.openjdk.java.net/~bpb/8073214/webrev.00/
>
> Lines 316 and 342 in Properties.java are not strictly necessary but make it a little more fail-fast.
>
The update to Properties looks okay but the @throws is mis-aligned so
looks inconsistent with the other @throws in the methods.
The test should probably be renamed and the @summary changed to make it
clear that it's a test for load & store throw nulls rather than a
complete unit test for Properties.
-Alan
More information about the core-libs-dev
mailing list