RFR 8071667 : HashMap.computeIfAbsent() adds entry that HashMap.get() does not find.
Brent Christian
brent.christian at oracle.com
Mon Mar 23 19:23:37 UTC 2015
On 3/21/15 6:43 AM, Paul Sandoz wrote:
> On Mar 20, 2015, at 10:23 PM, Brent Christian <brent.christian at oracle.com> wrote:
>> Here's the latest:
>>
>> http://cr.openjdk.java.net/~bchristi/8071667/webrev.4/
>>
>> That should have everything.
>
> Looks good (i assumed all but the test code has remained unchanged).
Code-wise, yes. Doc-wise, it does include the suggested "function" ->
"(re)mapping function" wording change.
> Can you avoid using raw types?
> ...
>
> 125 private static void checkCME(Consumer code, boolean expectCME) {
The argument accepted by Consumer is superfluous; changed to Runnable.
> 136 private static BiFunction<String,String,String> mkBiFunc(Map map) {
Map -> Map<String,String>
Webrev updated in place.
Thanks,
-Brent
More information about the core-libs-dev
mailing list