RFR [9] 8071472: Add field setter API for setting final fields in readObject

[Chris Hegarty]

Thanks for the feedback Alan.

On 24 Mar 2015, at 11:27, Alan Bateman <Alan.Bateman at oracle.com> wrote:

> On 23/03/2015 15:45, Chris Hegarty wrote:
>> Here is an updated version of the FieldSetter API, with all comments to date incorporated.
>> 
>> 
>> http://cr.openjdk.java.net/~chegar/8071472/02/specdiff/overview-summary.html 
>> 
>> Final spec comments welcome, after which I intend to submit a CCC request.
> 
> In fieldSetter() then a small typo "associate with current object" => missing "the”.

Fixed.

> Also in fieldSetter() then the first sentence might be clearer if you split it into two with the second sentence starting as "The FieldSetter gives write access ...”.

Changed.

> In FieldSetter then the first sentence might read a bit better if you change "including final" to "including final fields".

Changed.

> A suggestion for the second sentence is to change is to: "A thread executing readObject gets the FieldSetter by invoking the fieldSetter() method. The FieldSetter can be used to set any instance field of the object being deserialized”.

Accepted, and changed. With the addition that it is limited to fields declared by the class where the readObject is.

> In the third sentence then it might read a bit better if you drop the comma before "where applicable”.

Changed.

> I wonder if it might make sense to just drop the paragraph that lists the conditions for which ISE and IAE are thrown as this is repeated in each of the set methods.

I did flip-flop on this a few times. It is superfluous, and now removed.

> Otherwise it looks good to me.

Thanks,

Updated:
  http://cr.openjdk.java.net/~chegar/8071472/03/specdiff/

-Chris.

> -Alan.