JEP 102 Process Review

[Chris Hegarty]

On 24 Mar 2015, at 17:32, Roger Riggs <Roger.Riggs at Oracle.com> wrote:
...
>> 2) Can ProcessImpl.waitForProcessExit and its native counterpart be
>>     removed? ( since its function is now performed through ProcessHandleImpl )
> I'll look at that again; the two behaviors:
> 1) waiting for and reaping the exit value used by Process passes a pid/windows handle is one case,
> 2) waiting for a pid and not touching the exit value passing a pid is the other used by ProcessHandle.
> It currently passes a flag argument but may be better as two different native methods,
> considering that Process no longer extends ProcessHandle.

Oh, I wasn’t able to find an use of ProcessImpl.waitForProcessExit, so I thought it could be removed. Not necessary, if it is being used.

>> ...
>> 5) Could the fields for Info be private final, and use a separate
>>     private holder for retrieving the information from native?
>>     Seems desirable for them to be final.
> The implementation class is package private and only exposes the Info interface.
> What is the concern?  adding another class doesn't seem worth the overhead
> or complexity.

No major concern. It just appeared that Info could be immutable. An additional private “holder” class could be used.

-Chris.