RFR: JDK-8073158 zip files with total entry count 0xFFFF need not be ZIP64 files

Martin Buchholz martinrb at google.com
Wed Mar 25 16:55:09 UTC 2015


Yeah, this review is kinda scary.  There's a lot of technical debt here,
and this change only addresses some of it.

A variant of this code is in use at Google.

On Mon, Mar 23, 2015 at 1:18 PM, Martin Buchholz <martinrb at google.com>
wrote:

> Hi Xueming and Alan,
>
> I'd like you to do a code review.
>
> https://bugs.openjdk.java.net/browse/JDK-8073158
>
> http://cr.openjdk.java.net/~martin/webrevs/openjdk9/0xffff-entries-zip-file/
>
> Of course, the really correct thing is to have at most one zip
> implementation per programming language, but I'm not trying to fix that
> here (how many zip implementations does openjdk have?)
>



More information about the core-libs-dev mailing list