RFR: 7113878: LogManager - namedLoggers should be ConcurrentHashMap instead of Hashtable

Mandy Chung mandy.chung at oracle.com
Fri Mar 27 21:47:56 UTC 2015


On 3/27/15 4:27 AM, Daniel Fuchs wrote:
> Here is a new webrev - with Peter's suggestion implemented.
> I also made a few tweaks to the test.
>
> http://cr.openjdk.java.net/~dfuchs/webrev_7113878/webrev.01/


This version looks good to me.  With this change to use CHM,
we could modernize the code further and that's for some other day.

I think the removeLoggerRef andgetLoggerNames method don't
need to be synchronized either - any reason why they are
kept synchronized?

line 659: indent to the right
line 660: nit - 4-space indentation.

Mandy




More information about the core-libs-dev mailing list